Files
RedditBot/apps/dashboard/src/components/unsaved-changes.tsx
T
Jamie BruntonandClaude Opus 5 c43e534cf1 refactor(dashboard): rethink settings, split out subreddits and accounts
The settings page had accumulated five tabs whose names no longer matched
their contents, three different save models, and the whole subreddit
configuration buried under a tab named after a checkbox.

Structure:
- Subreddits becomes its own page: a list showing each community's mode,
  tone, computed share of polling, and live sent/reply stats, with one
  subreddit edited at a time in a drawer.
- Accounts becomes its own page. It is session lifecycle, not config.
- Settings collapses to one scrolling page: Safety, Pacing (Monitoring and
  Rate limits merged), Targeting, Notifications, Advanced.
- The sidebar is grouped, having gone from 9 to 11 destinations.

Saving:
- Every section owns its own draft, validation, risk gate and save via
  useConfigCard, submitting only the keys it owns. A syntax error in the
  advanced JSON can no longer block a rate-limit change, and enabling an
  autonomous policy is its own deliberate commit.
- UnsavedChangesProvider restores the leave-page guard across cards that no
  longer share a draft.

Subreddit editing:
- Errors are keyed by field name instead of array index, removing the
  defensive invalidation that existed because row indices shifted on add
  and remove. Confirming an autonomous mode can no longer be attributed to
  the wrong row.
- Weight is shown as the share it actually produces, live while editing.
- Bulk actions cover start/pause polling, tone, policy and removal, because
  production runs 30-40 subreddits and per-row editing does not scale.
  Bulk policy changes name every subreddit turning autonomous, and
  normalise the hybrid mode's turn budget, which has no form to catch it.

Physique targeting moves into its own Targeting card. It sends only
reddit.physiqueTargeting, which the config route applies independently, so
it cannot clobber the pacing card's fields. Turning screening on now warns
that it will reduce how many posts qualify.

Also surfaces the effective sending rate, since the hourly limit and the
minimum delay both throttle and only the binding one matters.

Legacy ?section= links redirect or resolve to anchors.

Fixes found while verifying in a browser: a radio-card rule was shrinking
nested number inputs; .share-preview had no styles; the throughput readout
reported a rate from a blank field; and the reconcile logic warned about a
server change whenever a sibling card saved.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-11 09:07:31 +01:00

95 lines
3.4 KiB
TypeScript

import {
createContext,
useCallback,
useContext,
useEffect,
useMemo,
useState,
type PropsWithChildren,
type ReactNode,
} from 'react';
import { useBlocker } from 'react-router-dom';
import { Modal } from './modal.js';
interface UnsavedChangesContextValue {
register(id: string, isDirty: boolean): void;
release(id: string): void;
}
const UnsavedChangesContext = createContext<UnsavedChangesContextValue | null>(null);
/**
* Page-level guard for a screen made of independently saved cards.
*
* Each card reports its own dirty state by id, so the guard can warn about
* leaving while *any* card has unsaved edits without the cards needing to
* share a draft. Section switches within a page do not trip it: only a
* pathname change is blocked.
*/
export function UnsavedChangesProvider({ children }: PropsWithChildren): ReactNode {
const [dirtyIds, setDirtyIds] = useState<readonly string[]>([]);
const register = useCallback((id: string, isDirty: boolean) => {
setDirtyIds((current) => {
const isTracked = current.includes(id);
if (isDirty === isTracked) return current;
return isDirty ? [...current, id] : current.filter((item) => item !== id);
});
}, []);
const release = useCallback((id: string) => {
setDirtyIds((current) => (current.includes(id) ? current.filter((item) => item !== id) : current));
}, []);
const value = useMemo(() => ({ register, release }), [register, release]);
const hasUnsavedChanges = dirtyIds.length > 0;
useEffect(() => {
if (!hasUnsavedChanges) return;
function warnBeforeUnload(event: BeforeUnloadEvent) {
event.preventDefault();
event.returnValue = '';
}
window.addEventListener('beforeunload', warnBeforeUnload);
return () => window.removeEventListener('beforeunload', warnBeforeUnload);
}, [hasUnsavedChanges]);
const blocker = useBlocker(({ currentLocation, nextLocation }) =>
hasUnsavedChanges && currentLocation.pathname !== nextLocation.pathname);
return (
<UnsavedChangesContext.Provider value={value}>
{children}
{blocker.state === 'blocked' ? (
<Modal className="dialog-card" labelledBy="unsaved-changes-title" onClose={() => blocker.reset()}>
<span className="eyebrow">Unsaved changes</span>
<h2 id="unsaved-changes-title">Leave without saving?</h2>
<p>
{dirtyIds.length === 1
? 'One section has edits that have not been saved. Leaving will discard them.'
: `${dirtyIds.length} sections have edits that have not been saved. Leaving will discard them.`}
</p>
<div className="dialog-actions">
<button autoFocus className="button secondary" onClick={() => blocker.reset()} type="button">Stay</button>
<button className="button danger" onClick={() => blocker.proceed()} type="button">Discard and leave</button>
</div>
</Modal>
) : null}
</UnsavedChangesContext.Provider>
);
}
/**
* Reports a card's dirty state to the surrounding {@link UnsavedChangesProvider}.
* Safe to call with no provider mounted, which keeps cards usable in isolation.
*/
export function useUnsavedChangesFlag(id: string, isDirty: boolean): void {
const context = useContext(UnsavedChangesContext);
useEffect(() => {
context?.register(id, isDirty);
}, [context, id, isDirty]);
useEffect(() => () => context?.release(id), [context, id]);
}