feat: dashboard UI/UX overhaul from full review
Shared foundation: - New Modal component on native <dialog>.showModal() (focus trap, inert background, Escape, focus restore, scroll lock); all eight dialogs and both globalThis.confirm calls migrated to it - Design tokens for success/warning/danger surfaces; pill danger variant; .sr-only utility; toast layering above dialog backdrops; not-allowed cursor for validity-disabled buttons Conversations/attention: auto-scroll with jump-to-latest, per-conversation draft persistence, suggestion undo, 30s auto-refresh with refresh controls, unread emphasis and counts, blur-consistent share dialog, empty-accounts guidance, collapsed user lookup, relative timestamps, danger pills for critical items Media/library/outreach: click-blurred-to-reveal, lightbox with arrow navigation and captions, dirty-form preservation across refetches, upload validation with thumbnail preview, save feedback, result counts with load-more and clear-filters, ticking countdowns from a single clock Overview/performance/operations/settings: mutation errors inside the confirm dialog, live sending-window countdown, offline-aware loading states, per-panel loading/error with retry, 7/30/90-day range toggle, console scroll yielding with shown/retained counts, risky-save matching by subreddit name instead of index, useBlocker unsaved-changes guard, single-pass validation with focus-to-first-error, access panel JSON validation and input reset Tests: 806 -> 844 passing; both typechecks clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
82be197b79
commit
e984bf20ac
46 files changed
+2462
-495
No files matched your search
@@ -1,8 +1,8 @@
|
||||
import { useMemo, useState } from 'react';
|
||||
import { filterMedia, mediaConversation, type MediaFilters } from './filters.js';
|
||||
import { useEffect, useMemo, useState } from 'react';
|
||||
import { filterMedia, mediaAlt, mediaConversation, type MediaFilters } from './filters.js';
|
||||
import { FullSyncDialog } from './full-sync-dialog.js';
|
||||
import { MediaCard } from './media-card.js';
|
||||
import { MediaPreviewDialog } from './media-preview-dialog.js';
|
||||
import { MediaPreviewDialog, type MediaPreviewEntry } from './media-preview-dialog.js';
|
||||
import { useMediaQuery, useMediaSyncStatusQuery, useTriggerMediaSyncMutation } from './queries.js';
|
||||
import './media.css';
|
||||
|
||||
@@ -13,6 +13,9 @@ export const initialMediaFilters: MediaFilters = {
|
||||
dateRange: 'all',
|
||||
};
|
||||
|
||||
const PAGE_SIZE = 48;
|
||||
const SUCCESS_NOTICE_MS = 5_000;
|
||||
|
||||
function errorMessage(error: Error | null): string {
|
||||
return error?.message ?? 'Something went wrong.';
|
||||
}
|
||||
@@ -36,9 +39,11 @@ export function MediaPage({ filters: controlledFilters, onFiltersChange }: Media
|
||||
const [isRevealAll, setIsRevealAll] = useState(false);
|
||||
const [isFullSyncDialogOpen, setIsFullSyncDialogOpen] = useState(false);
|
||||
const [previewItemId, setPreviewItemId] = useState<string | null>(null);
|
||||
const [visibleLimit, setVisibleLimit] = useState(PAGE_SIZE);
|
||||
|
||||
const items = mediaQuery.data ?? [];
|
||||
const visibleItems = useMemo(() => filterMedia(items, filters, Date.now()), [items, filters]);
|
||||
const displayedItems = visibleItems.slice(0, visibleLimit);
|
||||
const conversations = useMemo(
|
||||
() => [...new Set(items.map(mediaConversation))].sort((left, right) => left.localeCompare(right)),
|
||||
[items],
|
||||
@@ -48,12 +53,37 @@ export function MediaPage({ filters: controlledFilters, onFiltersChange }: Media
|
||||
[items],
|
||||
);
|
||||
const isSyncBusy = statusQuery.data?.isSyncing === true || syncMutation.isPending;
|
||||
const previewItem = items.find((item) => item.id === previewItemId) ?? null;
|
||||
const isFiltered = filters.conversation !== 'all' || filters.sender !== 'all' || filters.type !== 'all' || filters.dateRange !== 'all';
|
||||
const previewIndex = previewItemId === null ? -1 : visibleItems.findIndex((item) => item.id === previewItemId);
|
||||
const previewEntries: MediaPreviewEntry[] = useMemo(
|
||||
() => visibleItems.map((item) => ({
|
||||
id: item.id,
|
||||
src: item.urlPath,
|
||||
alt: mediaAlt(item),
|
||||
label: `Media from ${item.sender}`,
|
||||
captionTitle: `u/${item.sender}`,
|
||||
captionSubtitle: formatLastSync(item.timestamp),
|
||||
})),
|
||||
[visibleItems],
|
||||
);
|
||||
|
||||
function updateFilter<Key extends keyof MediaFilters>(key: Key, value: MediaFilters[Key]) {
|
||||
const next = { ...filters, [key]: value };
|
||||
const isSyncSuccess = syncMutation.isSuccess;
|
||||
useEffect(() => {
|
||||
if (!isSyncSuccess) return;
|
||||
const timer = setTimeout(() => syncMutation.reset(), SUCCESS_NOTICE_MS);
|
||||
return () => clearTimeout(timer);
|
||||
// syncMutation is a fresh object every render; keying on isSuccess is intentional.
|
||||
// eslint-disable-next-line react-hooks/exhaustive-deps
|
||||
}, [isSyncSuccess]);
|
||||
|
||||
function updateFilters(next: MediaFilters) {
|
||||
if (controlledFilters === undefined) setLocalFilters(next);
|
||||
onFiltersChange?.(next);
|
||||
setVisibleLimit(PAGE_SIZE);
|
||||
}
|
||||
|
||||
function updateFilter<Key extends keyof MediaFilters>(key: Key, value: MediaFilters[Key]) {
|
||||
updateFilters({ ...filters, [key]: value });
|
||||
}
|
||||
|
||||
function toggleItem(itemId: string) {
|
||||
@@ -90,7 +120,15 @@ export function MediaPage({ filters: controlledFilters, onFiltersChange }: Media
|
||||
<div className="page-state error-state" role="alert">
|
||||
<strong>Media unavailable</strong>
|
||||
<span>{errorMessage(mediaQuery.error)}</span>
|
||||
<button className="button secondary" onClick={() => void mediaQuery.refetch()} type="button">Retry media</button>
|
||||
<button
|
||||
aria-busy={mediaQuery.isFetching || undefined}
|
||||
className="button secondary"
|
||||
disabled={mediaQuery.isFetching}
|
||||
onClick={() => void mediaQuery.refetch()}
|
||||
type="button"
|
||||
>
|
||||
{mediaQuery.isFetching ? 'Refreshing…' : 'Retry media'}
|
||||
</button>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
@@ -106,11 +144,9 @@ export function MediaPage({ filters: controlledFilters, onFiltersChange }: Media
|
||||
<div className="header-actions">
|
||||
{items.length > 0 ? (
|
||||
<button
|
||||
aria-pressed={isRevealAll}
|
||||
className="button secondary"
|
||||
onClick={() => {
|
||||
setIsRevealAll((current) => !current);
|
||||
setRevealedIds(new Set());
|
||||
}}
|
||||
onClick={() => setIsRevealAll((current) => !current)}
|
||||
type="button"
|
||||
>
|
||||
{isRevealAll ? 'Blur all media' : 'Reveal all media'}
|
||||
@@ -127,7 +163,7 @@ export function MediaPage({ filters: controlledFilters, onFiltersChange }: Media
|
||||
>
|
||||
Full sync
|
||||
</button>
|
||||
<button className="button primary" disabled={isSyncBusy} onClick={() => runSync(false)} type="button">
|
||||
<button aria-busy={isSyncBusy || undefined} className="button primary" disabled={isSyncBusy} onClick={() => runSync(false)} type="button">
|
||||
{isSyncBusy ? 'Syncing…' : 'Sync new media'}
|
||||
</button>
|
||||
</div>
|
||||
@@ -138,7 +174,15 @@ export function MediaPage({ filters: controlledFilters, onFiltersChange }: Media
|
||||
{statusQuery.isError ? (
|
||||
<div role="alert">
|
||||
<span>{errorMessage(statusQuery.error)}</span>
|
||||
<button className="button secondary" onClick={() => void statusQuery.refetch()} type="button">Retry sync status</button>
|
||||
<button
|
||||
aria-busy={statusQuery.isFetching || undefined}
|
||||
className="button secondary"
|
||||
disabled={statusQuery.isFetching}
|
||||
onClick={() => void statusQuery.refetch()}
|
||||
type="button"
|
||||
>
|
||||
{statusQuery.isFetching ? 'Refreshing…' : 'Retry sync status'}
|
||||
</button>
|
||||
</div>
|
||||
) : null}
|
||||
{statusQuery.data ? (
|
||||
@@ -188,22 +232,45 @@ export function MediaPage({ filters: controlledFilters, onFiltersChange }: Media
|
||||
<option value="all">Any time</option><option value="24h">Past 24 hours</option><option value="7d">Past 7 days</option><option value="30d">Past 30 days</option>
|
||||
</select>
|
||||
</label>
|
||||
<div className="media-filter-summary">
|
||||
<span role="status">Showing {displayedItems.length} of {items.length} items</span>
|
||||
{isFiltered ? (
|
||||
<button className="button secondary" onClick={() => updateFilters(initialMediaFilters)} type="button">
|
||||
Clear filters
|
||||
</button>
|
||||
) : null}
|
||||
</div>
|
||||
</section>
|
||||
|
||||
{visibleItems.length === 0 ? (
|
||||
<section className="panel empty-state"><strong>No media matches these filters.</strong><span>Try broadening one or more filters.</span></section>
|
||||
) : (
|
||||
<section aria-label="Media gallery" className="media-grid">
|
||||
{visibleItems.map((item) => (
|
||||
<MediaCard
|
||||
isRevealed={isRevealAll || revealedIds.has(item.id)}
|
||||
item={item}
|
||||
key={item.id}
|
||||
onOpenPreview={() => setPreviewItemId(item.id)}
|
||||
onToggleReveal={() => toggleItem(item.id)}
|
||||
/>
|
||||
))}
|
||||
<section className="panel empty-state">
|
||||
<strong>No media matches these filters.</strong>
|
||||
<span>Try broadening one or more filters.</span>
|
||||
<button className="button secondary" onClick={() => updateFilters(initialMediaFilters)} type="button">
|
||||
Clear filters
|
||||
</button>
|
||||
</section>
|
||||
) : (
|
||||
<>
|
||||
<section aria-label="Media gallery" className="media-grid">
|
||||
{displayedItems.map((item) => (
|
||||
<MediaCard
|
||||
isRevealed={isRevealAll || revealedIds.has(item.id)}
|
||||
item={item}
|
||||
key={item.id}
|
||||
onOpenPreview={() => setPreviewItemId(item.id)}
|
||||
onToggleReveal={() => toggleItem(item.id)}
|
||||
/>
|
||||
))}
|
||||
</section>
|
||||
{visibleItems.length > displayedItems.length ? (
|
||||
<div className="media-load-more">
|
||||
<button className="button secondary" onClick={() => setVisibleLimit((current) => current + PAGE_SIZE)} type="button">
|
||||
Load more ({visibleItems.length - displayedItems.length} remaining)
|
||||
</button>
|
||||
</div>
|
||||
) : null}
|
||||
</>
|
||||
)}
|
||||
</>
|
||||
)}
|
||||
@@ -215,7 +282,14 @@ export function MediaPage({ filters: controlledFilters, onFiltersChange }: Media
|
||||
onConfirm={() => runSync(true)}
|
||||
/>
|
||||
) : null}
|
||||
{previewItem ? <MediaPreviewDialog item={previewItem} onClose={() => setPreviewItemId(null)} /> : null}
|
||||
{previewIndex >= 0 ? (
|
||||
<MediaPreviewDialog
|
||||
entries={previewEntries}
|
||||
index={previewIndex}
|
||||
onClose={() => setPreviewItemId(null)}
|
||||
onNavigate={(nextIndex) => setPreviewItemId(visibleItems[nextIndex]?.id ?? null)}
|
||||
/>
|
||||
) : null}
|
||||
</div>
|
||||
);
|
||||
}
|
||||
Reference in new issue
Block a user