fix: revalidate authentication before bot start

This commit is contained in:
jjbrunton committed 2026-08-10 21:10:12 +01:00
1 parent 8ea1cf16d4
commit 11b6300113
5 files changed
+101 -13

No files matched your search

+72 -1
View File
@@ -16,7 +16,12 @@ describe('bot control account authentication gate', () => {
const setBotRunning = vi.fn();
const app = express();
app.use(createControlRouter({
services: { accountAuth: { isFullyAuthenticated: () => false } },
services: {
accountAuth: {
isFullyAuthenticated: () => false,
ensureFullyAuthenticated: vi.fn(async () => false),
},
},
setBotRunning,
activity: { push: vi.fn() },
logger: { warn: vi.fn(), info: vi.fn() },
@@ -32,4 +37,70 @@ describe('bot control account authentication gate', () => {
expect(await response.json()).toMatchObject({ success: false, authenticated: false });
expect(setBotRunning).not.toHaveBeenCalled();
});
it('renews an expired authentication lease before starting the bot', async () => {
let running = false;
const ensureFullyAuthenticated = vi.fn(async () => true);
const app = express();
app.use(createControlRouter({
config: { browser: { dryRun: false } },
services: {
accountAuth: {
isFullyAuthenticated: () => false,
ensureFullyAuthenticated,
},
},
getBotRunning: () => running,
setBotRunning: (next: boolean) => { running = next; },
activity: { push: vi.fn() },
logger: { warn: vi.fn(), info: vi.fn() },
broadcaster: { dashboardEvents: { bot: vi.fn() } },
} as never));
const server = app.listen(0);
servers.push(server);
await new Promise<void>((resolve) => server.once('listening', resolve));
const { port } = server.address() as AddressInfo;
const response = await fetch(`http://127.0.0.1:${port}/start`, { method: 'POST' });
expect(response.status).toBe(200);
expect(await response.json()).toMatchObject({ success: true, running: true });
expect(ensureFullyAuthenticated).toHaveBeenCalledOnce();
expect(running).toBe(true);
});
it('renews a running account runtime when the legacy auth context is unavailable', async () => {
let running = false;
const ensureFullyAuthenticated = vi.fn(async () => true);
const runtime = {
resources: {
accountAuth: { isFullyAuthenticated: () => false, ensureFullyAuthenticated },
},
};
const app = express();
app.use(createControlRouter({
config: { browser: { dryRun: false } },
services: {
accountRuntimes: {
list: () => [{ accountId: '@t2_account:reddit.com', state: 'running' }],
get: () => runtime,
},
},
getBotRunning: () => running,
setBotRunning: (next: boolean) => { running = next; },
activity: { push: vi.fn() },
logger: { warn: vi.fn(), info: vi.fn() },
broadcaster: { dashboardEvents: { bot: vi.fn() } },
} as never));
const server = app.listen(0);
servers.push(server);
await new Promise<void>((resolve) => server.once('listening', resolve));
const { port } = server.address() as AddressInfo;
const response = await fetch(`http://127.0.0.1:${port}/start`, { method: 'POST' });
expect(response.status).toBe(200);
expect(ensureFullyAuthenticated).toHaveBeenCalledOnce();
expect(running).toBe(true);
});
});